Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace resolve with require.resolve #283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kherock
Copy link
Contributor

@kherock kherock commented Mar 28, 2022

This project currently uses the resolve package to resolve paths despite it being a plain Node.js application. Currently, this package doesn't really suffer from any major issues because of this aside from being unable to resolve require hooks that use package exports maps rather than main, due to this issue browserify/resolve#222 (comment).

Since this library only targets Node, we should be able to drop the resolution helpers for the native thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant